Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coral-Trino] Fix failing unit tests after PR 434 #482

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

ljfgem
Copy link
Collaborator

@ljfgem ljfgem commented Dec 20, 2023

What changes are proposed in this pull request, and why are they necessary?

#434 doesn't modify some existing unit test results, which are fixed by this PR.
(My bad, I merged #434 without taking another look at the GitHub CI result.)

How was this patch tested?

./gradlew clean build succeeded with this PR.

@ljfgem
Copy link
Collaborator Author

ljfgem commented Dec 20, 2023

@aastha25 @KevinGe00 could you please take a look at it?

@jerryleooo
Copy link
Contributor

my bad, thank @ljfgem for the help

Copy link
Contributor

@KevinGe00 KevinGe00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ljfgem ljfgem merged commit dfec3ba into linkedin:master Dec 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants